snuyanzin opened a new pull request, #22007:
URL: https://github.com/apache/flink/pull/22007

   ## What is the purpose of the change
   After https://issues.apache.org/jira/browse/FLINK-29945 sql client started 
to close the session in case some invalid queries rather than just fail with 
error and allow user to enter another one. 
   
   example of queries
   ```sql
   SELECT /*;
   
   SELECT @;
   
   SELECT #;
   ```
   
   It seems that before this change all the parser exceptions are handled via 
`org.apache.calcite.sql.parser.SqlAbstractParserImpl#normalizeException` which 
under the hood catches `TokenMgrError`. Now it works directly with 
`TokenIterator` that's why extra catch is required.
   
   ## Verifying this change
   
   The test query reproducing the issue added to 
_flink-table/flink-sql-client/src/test/resources/sql/select.q_
   
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: ( no)
     - The serializers: ( no )
     - The runtime per-record code paths (performance sensitive): ( no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
     - The S3 file system connector: ( no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable )
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to