rkhachatryan commented on code in PR #21981:
URL: https://github.com/apache/flink/pull/21981#discussion_r1116364006
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/SlotAllocator.java:
##########
@@ -54,6 +54,18 @@ public interface SlotAllocator {
Optional<? extends VertexParallelism> determineParallelism(
JobInformation jobInformation, Collection<? extends SlotInfo>
slots);
+ /**
+ * Same as {@link #determineParallelism(JobInformation, Collection)} but
additionally determine
+ * assignment of slots to execution slot sharing groups.
+ */
+ default Optional<? extends VertexParallelismWithSlotSharing>
Review Comment:
After an offline discussion, I restructured the interfaces
(4fa93e3756fad77cf2dbc92bf77614aa39cc28fe..2fc84d83884c1f342d46fec02d961d4f73eb4219).
This particular comment is addressed by
4fa93e3756fad77cf2dbc92bf77614aa39cc28fe:
```
Restructure 1/5: change types passed between AdaptiveScheduler and
SlotAssigner
Slot assignments are computed and consumed by SlotAllocator.
This is expressed implicitly by implementing VertexParallelism.
This change tries to make that clear, while still allowing to assign
slots to something other than slot sharing groups.
It does so by:
1. Introduce JobSchedulingPlan, computed and consumed by SlotAllocator. It
couples VertexParallelism with slot assignments.
2. Push the polymorphism of state assignments from VertexParallelism to slot
assignment target in JobSchedulingPlan.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
