JingsongLi commented on code in PR #555:
URL: https://github.com/apache/flink-table-store/pull/555#discussion_r1116440000
##########
flink-table-store-hive/flink-table-store-hive-catalog/pom.xml:
##########
@@ -535,6 +535,65 @@ under the License.
<groupId>org.jamon</groupId>
<artifactId>jamon-runtime</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-exec</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <!--
+ Why we need this test dependency:
+ IDEA reads classes from the same project from target/classes of that
module,
+ so even though we've packaged and shaded avro classes into
flink-table-store-format.jar
+ we still have to include this test dependency here.
+
+ Why do we put this test dependency before the provided hive-exec:
+ hive-exec produces a shaded jar which contains old versioned avro
classes,
+ so we need to make sure that our newer avro is loaded first.
+ -->
+ <dependency>
+ <groupId>org.apache.avro</groupId>
+ <artifactId>avro</artifactId>
+ <version>${avro.version}</version>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-exec</artifactId>
+ <version>${hive.version}</version>
+ <scope>provided</scope>
Review Comment:
test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
