rkhachatryan commented on code in PR #21981:
URL: https://github.com/apache/flink/pull/21981#discussion_r1116928384
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java:
##########
@@ -116,66 +116,53 @@ public Collection<SlotAssignment> assignSlots(
JobInformation jobInformation,
Collection<? extends SlotInfo> freeSlots,
VertexParallelism vertexParallelism) {
- Collection<? extends SlotInfo> remainingSlots = freeSlots;
- final Collection<SlotAssignment> assignments = new ArrayList<>();
+ final List<ExecutionSlotSharingGroup> allGroups = new ArrayList<>();
for (SlotSharingGroup slotSharingGroup :
jobInformation.getSlotSharingGroups()) {
-
- List<ExecutionSlotSharingGroup> sharedSlotToVertexAssignment =
- createExecutionSlotSharingGroups(vertexParallelism,
slotSharingGroup);
-
- SlotAssigner.AssignmentResult result =
- assignSlots(remainingSlots, sharedSlotToVertexAssignment);
- remainingSlots = result.remainingSlots;
- assignments.addAll(result.assignments);
+
allGroups.addAll(createExecutionSlotSharingGroups(vertexParallelism,
slotSharingGroup));
}
- return assignments;
- }
-
- private AssignmentResult assignSlots(
Review Comment:
Addressed by d3595c472e38a96b66a9ee7ac1a394706802d431.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
