RocMarshal commented on code in PR #21999:
URL: https://github.com/apache/flink/pull/21999#discussion_r1116991198
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java:
##########
@@ -945,12 +982,15 @@ public void
testAsyncCheckpointingConcurrentCloseBeforeAcknowledge() throws Exce
// make sure that all state handles have been discarded
discardFuture.get();
- try {
- mockEnvironment.getAcknowledgeCheckpointFuture().get(10L,
TimeUnit.MILLISECONDS);
- fail("The checkpoint should not get acknowledged.");
- } catch (TimeoutException expected) {
- // future should not be completed
- }
+ assertThatThrownBy(
+ () -> {
+ // future should not be completed
+ mockEnvironment
+ .getAcknowledgeCheckpointFuture()
+ .get(10L, TimeUnit.MILLISECONDS);
+ fail("The checkpoint should not get
acknowledged.");
Review Comment:
Yes. I'll check the same cases in the test.
thx~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
