lincoln-lil commented on code in PR #21545:
URL: https://github.com/apache/flink/pull/21545#discussion_r1118010327
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/LookupJoinTest.scala:
##########
@@ -951,6 +951,58 @@ class LookupJoinTest(legacyTableSource: Boolean) extends
TableTestBase with Seri
util.verifyExplain(stmt, ExplainDetail.JSON_EXECUTION_PLAN)
}
+ @Test
+ def testJoinWithLookupJoinHint(): Unit = {
+ util.verifyExecPlan(
+ """
+ |SELECT /*+ LOOKUP('table'='D', 'retry-predicate'='lookup_miss',
+ |'retry-strategy'='fixed_delay', 'fixed-delay'='155 ms',
'max-attempts'='10',
+ |'async'='true', 'output-mode'='allow_unordered','capacity'='1000',
'time-out'='300 s')
+ |*/
+ |T.a
+ |FROM MyTable AS T
+ |JOIN LookupTable FOR SYSTEM_TIME AS OF T.proctime AS D
+ |ON T.a = D.id
+ |""".stripMargin
+ )
+ }
+
+ @Test
+ def testJoinWithCapitalizeLookupJoinHint(): Unit = {
Review Comment:
nit: rename to 'testJoinWithMixedCaseLookupJoinHint'
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/UnnestTest.scala:
##########
@@ -17,10 +17,25 @@
*/
package org.apache.flink.table.planner.plan.stream.sql
+import org.apache.flink.api.scala._
+import org.apache.flink.table.api._
import org.apache.flink.table.planner.plan.common.UnnestTestBase
import org.apache.flink.table.planner.utils.TableTestUtil
+import org.junit.Test
+
class UnnestTest extends UnnestTestBase(true) {
override def getTableTestUtil: TableTestUtil = streamTestUtil()
+
+ @Test
+ def testUnnestWithLookupJoinHint(): Unit = {
Review Comment:
nit: rename to 'testUnnestWithInvalidLookupJoinHint'
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/LookupJoinTest.scala:
##########
@@ -951,6 +951,58 @@ class LookupJoinTest(legacyTableSource: Boolean) extends
TableTestBase with Seri
util.verifyExplain(stmt, ExplainDetail.JSON_EXECUTION_PLAN)
}
+ @Test
+ def testJoinWithLookupJoinHint(): Unit = {
Review Comment:
this can be merge with the 'testJoinWithInvalidPropagationToSubQuery',
rename to 'testJoinHintWithNoPropagatingToSubQuery'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
