JingsongLi commented on code in PR #558:
URL: https://github.com/apache/flink-table-store/pull/558#discussion_r1118245870
##########
flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/sink/TableStoreSink.java:
##########
@@ -88,6 +90,10 @@ public ChangelogMode getChangelogMode(ChangelogMode
requestedMode) {
return requestedMode;
}
+ if (options.get(MERGE_ENGINE) == MergeEngine.AGGREGATE) {
Review Comment:
Actually, this method `getChangelogMode(ChangelogMode requestedMode)` is
doing these logical. I think we don't need extract another method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
