godfreyhe commented on code in PR #22024:
URL: https://github.com/apache/flink/pull/22024#discussion_r1118269139
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/SorMergeJoinOperatorUtil.java:
##########
@@ -48,6 +49,17 @@ public static SortMergeJoinFunction getSortMergeJoinFunction(
double externalBufferMemRatio) {
int[] keyPositions = IntStream.range(0, leftKeys.length).toArray();
+ int maxNumFileHandles =
+
config.get(ExecutionConfigOptions.TABLE_EXEC_SORT_MAX_NUM_FILE_HANDLES);
+ boolean compressionEnable =
+
config.get(ExecutionConfigOptions.TABLE_EXEC_SPILL_COMPRESSION_ENABLED);
+ int compressionBlockSize =
+ (int)
+
config.get(ExecutionConfigOptions.TABLE_EXEC_SPILL_COMPRESSION_BLOCK_SIZE)
+ .getBytes();
+ boolean asyncMergeEnable =
Review Comment:
asyncMergeEnabled
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecHashJoin.java:
##########
@@ -213,6 +213,12 @@ protected Transformation<RowData> translateToPlanInternal(
condFunc,
1.0 * externalBufferMemory / managedMemory);
+ boolean compressionEnable =
Review Comment:
nit: compressionEnabled
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/SorMergeJoinOperatorUtil.java:
##########
@@ -48,6 +49,17 @@ public static SortMergeJoinFunction getSortMergeJoinFunction(
double externalBufferMemRatio) {
int[] keyPositions = IntStream.range(0, leftKeys.length).toArray();
+ int maxNumFileHandles =
+
config.get(ExecutionConfigOptions.TABLE_EXEC_SORT_MAX_NUM_FILE_HANDLES);
+ boolean compressionEnable =
Review Comment:
compressionEnabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
