SteNicholas commented on code in PR #558:
URL: https://github.com/apache/flink-table-store/pull/558#discussion_r1118476407
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/aggregate/FieldAggregator.java:
##########
@@ -67,8 +67,21 @@ static FieldAggregator createFieldAggregator(
"Use unsupported aggregation or spell aggregate
function incorrectly!");
}
}
+
+ if (ignoreRetract) {
+ fieldAggregator = new FieldIgnoreRetractAgg(fieldAggregator);
+ }
return fieldAggregator;
}
abstract Object agg(Object accumulator, Object inputField);
+
+ Object retract(Object accumulator, Object retractField) {
+ throw new UnsupportedOperationException(
+ String.format(
+ "Aggregate function %s dose not support retraction,"
Review Comment:
Better to use function name instead of the aggregator class name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
