gauravmiglanid11 commented on code in PR #533:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/533#discussion_r1118510968
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricEvaluator.java:
##########
@@ -66,12 +66,15 @@ public Map<JobVertexID, Map<ScalingMetric,
EvaluatedScalingMetric>> evaluate(
var scalingOutput = new HashMap<JobVertexID, Map<ScalingMetric,
EvaluatedScalingMetric>>();
var metricsHistory = collectedMetrics.getMetricHistory();
var topology = collectedMetrics.getJobTopology();
+ var excludeVertexIdList =
conf.get(AutoScalerOptions.EXCLUDE_VERTEX_IDS);
for (var vertex : topology.getVerticesInTopologicalOrder()) {
- scalingOutput.put(
- vertex,
- computeVertexScalingSummary(
- conf, scalingOutput, metricsHistory, topology,
vertex));
+ if (!excludeVertexIdList.contains(vertex.toHexString())) {
+ scalingOutput.put(
Review Comment:
as discussed, we will follow up with an additional change to ensure that
the ignored vertices do not affect their downstream vertices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
