Mr-Gump opened a new pull request, #22037:
URL: https://github.com/apache/flink/pull/22037

   ## What is the purpose of the change
   
   *This PR offers users an option to avoid passing event timestamp to Kafka., 
for the reason that in some cases, directly passing event timestamp to Kafka 
may cause Kafka segment deletion unexpectedly. For Example, I use Kafka source 
and Kafka sink transfer recodes from one topic to another, however, the target 
topic receives the data and deletes them in a short period. The reason is that 
event timestamps are directly transferred from source topic to target topic, 
and the data is published to Kafka just a week before. So It leads an automatic 
deletion in Kafka segment.*
   
   
   ## Brief change log
   
   *Add writeTimestamp option in KafkaRecordSerializationSchemaBuilder*
     - *Add a bool variable writeTimestamp and its setter.*
     - *Add an additional check for whether timestamp will be set to null.*
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
*[KafkaRecordSerializationSchemaBuilderTest](https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilderTest.java)*.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? not documented
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to