reswqa opened a new pull request, #22042:
URL: https://github.com/apache/flink/pull/22042

   ## What is the purpose of the change
   
   *The `JobVertexFlameGraphHandler` relies internally on the 
`JobVertexThreadInfoTracker` which calls
   `ResourceManagerGateway#requestTaskExecutorThreadInfoGateway` to get a 
gateway for requesting the thread info from the task executors. Since this 
gateway is not serializable it would categorically fail if called from a 
standby dispatcher.
   Instead this should follow the logic of the `MetricFetcherImpl`, which 
requests addresses instead and manually connects to the task executors.*
   
   
   ## Brief change log
   
     - *Abstract the logic of retrieve RpcGateway from address to 
`AddressBasedGatewayRetriver` and remove `MetricQueryServiceRetriever`.*
     - *Enrich `WorkerRegistration` with task executor address*
     - *`ThreadInfoRequestCoordinator` Fetch thread info the same way as 
`MetricFetcherImpl`.*
   
   
   ## Verifying this change
   
   This change can be covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to