[ 
https://issues.apache.org/jira/browse/FLINK-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573298#comment-15573298
 ] 

ASF GitHub Bot commented on FLINK-2184:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1975#discussion_r83308865
  
    --- Diff: 
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AllWindowedStream.scala
 ---
    @@ -361,38 +361,84 @@ class AllWindowedStream[T, W <: Window](javaStream: 
JavaAllWStream[T, W]) {
     
       /**
        * Applies an aggregation that that gives the maximum element of the 
window by
    -   * the given position. When equality, returns the first.
    +   * the given position. When equality, returns the first by default.
        */
       def maxBy(position: Int): DataStream[T] = 
aggregate(AggregationType.MAXBY,
    -    position)
    +    position, true)
     
       /**
        * Applies an aggregation that that gives the maximum element of the 
window by
    -   * the given field. When equality, returns the first.
    +   * the given position. When equality, returns either the first or last 
one depending
    +   * on the parameter setting.
    +   */
    +  def maxBy(position: Int, first: Boolean): DataStream[T] = 
aggregate(AggregationType.MAXBY,
    +    position, first)
    +
    +  /**
    +   * Applies an aggregation that that gives the maximum element of the 
window by
    --- End diff --
    
    typo `that that` copied from the other docs in this file. Could you please 
fix all of them? Thanks!


> Cannot get last element with maxBy/minBy
> ----------------------------------------
>
>                 Key: FLINK-2184
>                 URL: https://issues.apache.org/jira/browse/FLINK-2184
>             Project: Flink
>          Issue Type: Improvement
>          Components: Scala API, Streaming
>            Reporter: Gábor Hermann
>            Priority: Minor
>
> In the streaming Scala API there is no method
> {{maxBy(int positionToMaxBy, boolean first)}}
> nor
> {{minBy(int positionToMinBy, boolean first)}}
> like in the Java API, where _first_ set to {{true}} indicates that the latest 
> found element will return.
> These methods should be added to the Scala API too, in order to be consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to