reswqa opened a new pull request, #22060:
URL: https://github.com/apache/flink/pull/22060

   ## What is the purpose of the change
   
   *`SmokeKafkaITCase` only covered the application packaging test of 
datastream job, we should also bring this kind of test to sql job submitted by 
sql-client to cover the case of sql connector fat jar.
   In fact, we already have similar test class with the same purpose, that is 
`SQLClientKafkaITCase`, but this test is ignored since 2021/4/20. It depend on 
the
   `LocalStandaoneKafkaResource` which download `kafka` and sets up a local 
cluster, but we often encounter download failures in CI environments. 
Fortunately, now we prefer to use `TestContainer` in E2E test. So I suggest 
integrating the corresponding test logic into `SmokeKafkaITCase`, and then 
removing it*
   
   
   ## Brief change log
   
     - *Remove flink-streaming-kafka-test-base module.*
     - *Remove SQLClientKafkaITCase.*
     - *Add sql smoke test for kafka.*
   
   
   ## Verifying this change
   
   
   This change is already covered by existing tests.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to