dmvk commented on code in PR #22066: URL: https://github.com/apache/flink/pull/22066#discussion_r1122709873
########## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/CreatingExecutionGraph.java: ########## @@ -128,10 +129,10 @@ private void handleExecutionGraphCreation( () -> StreamSupport.stream( executionGraph - .getAllExecutionVertices() + .getVerticesTopologically() .spliterator(), false) - .map(v -> v.getJobVertex().getJobVertex()) + .map(ExecutionJobVertex::getJobVertex) .iterator(), Review Comment: nit: it would be nice to mark `updatedPlan` as final along-side the above change, to make it consistent with rest of the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org