rkhachatryan commented on PR #22022: URL: https://github.com/apache/flink/pull/22022#issuecomment-1451752308
Thanks for the review @dmvk! I've updated the both commit messages and marked `scheduledCommands` as `volatile`. > For the second commit >> Otherwise, any command with SINGLE_SUBTASK scope might be dispatched to a finished source. >> This will result in a timeout while waiting for this command to be executed. > > Can you please point me to where precisely the timeout is supposed to happen? As far as I can tell, on the source side, > we'd only add it to the queue (there will most likely be something on the executor side that I'm missing). Sure, the timeout happens in [`TestJobExecutor.waitForFailover`](https://github.com/apache/flink/blob/1993ad0c968efa60ad5071e8472f630b247251f0/flink-tests/src/test/java/org/apache/flink/runtime/operators/lifecycle/TestJobExecutor.java#L163). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
