rkhachatryan commented on code in PR #21923:
URL: https://github.com/apache/flink/pull/21923#discussion_r1124691916
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -733,8 +764,7 @@ void restoreInternal() throws Exception {
// needed
channelIOExecutor.shutdown();
- isRunning = true;
- isRestoring = false;
+ taskState.status = TaskState.Status.RUNNING;
Review Comment:
> now all transitions are correct
I'd add CANCELLING state to reflect the above combination of flags.
> I also don't think that we should get back to 4 flags since we already
spend a lot of time understanding which combinations of them are really possible
Makes sense. I'm not insisting on any option. As for the knowledge, should
we encode it as allowed state transitions? I believe it was there previously in
the PR, but then was deleted.
> I still think that we should even get rid of failing
👍 and it seems just necessary if we proceed with CAS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
