lilyevsky commented on code in PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1125187664
##########
flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchWriter.java:
##########
@@ -122,10 +128,11 @@
} catch (Exception e) {
throw new FlinkRuntimeException("Failed to open the
OpensearchEmitter", e);
}
+ this.failureHandler = failureHandler;
}
@Override
- public void write(IN element, Context context) throws IOException,
InterruptedException {
+ public void write(IN element, Context context) throws InterruptedException
{
Review Comment:
@reta No problem, could you please clarify: you want me to put back the
IOException to both write and flush methods, correct? Also, I am not sure what
you mean by addressing
[this](https://github.com/apache/flink-connector-opensearch/pull/11/files#r1110066551)
. Is it about removing the "@SuppressWarnings("All")"?
Please confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
