XComp commented on PR #21736: URL: https://github.com/apache/flink/pull/21736#issuecomment-1454533512
Not sure, whether I understand you in the right way here: I didn't mean to push the generated test da in multiple commits (e.g. one commit per test class). I meant that we want to prepare this PR to have one commit for the refactoring of the test data generation and one commit for the generated data. Does that make sense?🤔 But on the other note: I reiterated on your proposal for how the process should look like. I came to the conclusion that we shouldn't create the test data when creating the release branch. We still have to do it after the new minor release (in our current case 1.17.0) is published. The test data should be generated using the code version of the minor version's git tag (i.e. `release-1.17.0`). That's the baseline for migration tests. Therefore, it must be possible to control the `FlinkVersion.getMostRecentlyPublished()`'s return value. Automatically deriving it from the enum taking the element before the last element is not good enough . Do you agree? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
