[
https://issues.apache.org/jira/browse/FLINK-31224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696818#comment-17696818
]
Jingsong Lee commented on FLINK-31224:
--------------------------------------
Hi [~zhangjun] , thanks for your contribution.
My main concern is, do we really need these metrics, like file and rowCount,
some of them are already in snapshot meta.
I prefer to wait until the user needs are clear before providing these metrics.
What do you think?
> Add metrics for flink table store
> ---------------------------------
>
> Key: FLINK-31224
> URL: https://issues.apache.org/jira/browse/FLINK-31224
> Project: Flink
> Issue Type: Improvement
> Components: Table Store
> Affects Versions: table-store-0.3.1
> Reporter: Jun Zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: table-store-0.4.0
>
>
> We can divide the metrics of the flink table store into three categories:
> SourceMetrics, WriterMetrics, and CompactionMetrics
> Some metrics are as follows :
> {code:java}
> public class WriterMetrics {
> private final Counter deltaManifestCount;
> private final Counter deltaTotalFileSize;
> private final Counter deltaTotalRowCount;
> private final Counter changelogManifestCount;
> private final Counter changelogTotalFileSize;
> private final Counter changelogTotalRowCount;
> }
> public class SourceMetrics {
> private final Counter assignedSplits;
> private final Counter finishedSplits;
> private final Counter splitReaderFetchCalls;
> }
> public class CompactionMetrics {
> private final Counter beforeCompactionFileCount;
> private final Counter beforeCompactionDeltaTotalFileSize;
> private final Counter beforeCompactionDeltaTotalRowCount;
> private final Counter afterCompactionFileCount;
> private final Counter afterCompactionDeltaTotalFileSize;
> private final Counter afterCompactionDeltaTotalRowCount;
> private final Counter compactChangelogFileCount;
> private final Counter compactChangelogTotalFileSize;
> private final Counter compactChangelogTotalRowCount;
> }
> {code}
>
> My idea is that we may not know which metrics users really need at first. We
> can add some core metrics first, and then we can collect users' needs and add
> some user metrics later.
>
> [~lzljs3620320] [~nicholasjiang] do you have any advice? thanks
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
