tsreaper commented on code in PR #569:
URL: https://github.com/apache/flink-table-store/pull/569#discussion_r1126129142
##########
docs/content/docs/engines/hive.md:
##########
@@ -42,12 +42,12 @@ Table Store currently supports MR and Tez execution engine
for Hive.
Download the jar file with corresponding version.
-| |Jar|
-|---|---|
-|Hive 3.1|[flink-table-store-hive-connector-{{< version
>}}_3.1.jar](https://www.apache.org/dyn/closer.lua/flink/flink-table-store-{{<
version >}}/flink-table-store-hive-connector-{{< version >}}_3.1.jar)|
-|Hive 2.3|[flink-table-store-hive-connector-{{< version
>}}_2.3.jar](https://www.apache.org/dyn/closer.lua/flink/flink-table-store-{{<
version >}}/flink-table-store-hive-connector-{{< version >}}_2.3.jar)|
-|Hive 2.2|[flink-table-store-hive-connector-{{< version
>}}_2.2.jar](https://www.apache.org/dyn/closer.lua/flink/flink-table-store-{{<
version >}}/flink-table-store-hive-connector-{{< version >}}_2.2.jar)|
-|Hive 2.1|[flink-table-store-hive-connector-{{< version
>}}_2.1.jar](https://www.apache.org/dyn/closer.lua/flink/flink-table-store-{{<
version >}}/flink-table-store-hive-connector-{{< version >}}_2.1.jar)|
+| | Jar
|
+|---|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+|Hive 3.1| [flink-table-store-hive-connector-3.1-{{< version
>}}.jar](https://www.apache.org/dyn/closer.lua/flink/flink-table-store-{{<
version >}}/flink-table-store-hive-connector-{{< version >}}_3.1.jar) |
+|Hive 2.3| [flink-table-store-hive-connector-2.3-{{< version
>}}.jar](https://www.apache.org/dyn/closer.lua/flink/flink-table-store-{{<
version >}}/flink-table-store-hive-connector-{{< version >}}_2.3.jar)
|
+|Hive 2.2| [flink-table-store-hive-connector-2.2-{{< version
>}}.jar](https://www.apache.org/dyn/closer.lua/flink/flink-table-store-{{<
version >}}/flink-table-store-hive-connector-{{< version >}}_2.2.jar)
|
+|Hive 2.1| [flink-table-store-hive-connector-2.1-{{< version
>}}.jar](https://www.apache.org/dyn/closer.lua/flink/flink-table-store-{{<
version >}}/flink-table-store-hive-connector-{{< version >}}_2.1.jar)
|
Review Comment:
As we now have a separate module for Hive 2.1 CDH 6.3, we should also add a
row for that version in the document.
##########
.github/workflows/build-different-versions.yml:
##########
@@ -16,12 +16,3 @@ jobs:
- name: Build
run: |
./mvnw clean install -Dmaven.test.skip=true
- - name: Build Hive 3.1
- run: |
- ./mvnw clean install -Dmaven.test.skip=true -Phive-3.1 -f
flink-table-store-hive
- - name: Build Hive 2.2
- run: |
- ./mvnw clean install -Dmaven.test.skip=true -Phive-2.2 -f
flink-table-store-hive
- - name: Build Hive 2.1
- run: |
- ./mvnw clean install -Dmaven.test.skip=true -Phive-2.1 -f
flink-table-store-hive
Review Comment:
Remove this whole file. No more different versions to check now.
##########
docs/content/docs/engines/hive.md:
##########
@@ -62,16 +62,9 @@ You are using an unreleased version of Table Store so you
need to manually build
To build from source code, either [download the source of a
release](https://flink.apache.org/downloads.html) or [clone the git
repository]({{< github_repo >}}).
Build bundled jar with the following command.
+`mvn clean install -Dmaven.test.skip=true`
-| Version | Command |
-|---|---|
-| Hive 3.1 | `mvn clean install -Dmaven.test.skip=true -Phive-3.1` |
-| Hive 2.3 | `mvn clean install -Dmaven.test.skip=true` |
-| Hive 2.2 | `mvn clean install -Dmaven.test.skip=true -Phive-2.2` |
-| Hive 2.1 | `mvn clean install -Dmaven.test.skip=true -Phive-2.1` |
-| Hive 2.1 CDH 6.3 | `mvn clean install -Dmaven.test.skip=true
-Phive-2.1-cdh-6.3` |
-
-You can find Hive connector jar in
`./flink-table-store-hive/flink-table-store-hive-connector/target/flink-table-store-hive-connector-{{<
version >}}.jar`.
+For hive-2.3, you can find Hive connector jar in
`./flink-table-store-hive/flink-table-store-hive-connector-2.3/target/flink-table-store-hive-connector-2.3-{{<
version >}}.jar`.
Review Comment:
```suggestion
You can find Hive connector jar in
`./flink-table-store-hive/flink-table-store-hive-connector-2.3/target/flink-table-store-hive-connector-<hive-version>-{{<
version >}}.jar`.
```
I also suggest changing the description in Flink's document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
