mas-chen opened a new pull request, #6:
URL: https://github.com/apache/flink-connector-kafka/pull/6

   …or so that checkpoints can correctly fail
   
   -->
   
   ## What is the purpose of the change
   
   Fixes a regression when the checkpoint completes although there is an error. 
The exception is never thrown before checkpoint completing because the 
exception throwing logic is enqueued to separate task, during checkpointing.
   
   ## Brief change log
   
   - Propagate exception and throw them in write/flush/close methods.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Added unit tests and ran existing unit tests, integration tests, and e2e 
tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): yes
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to