[
https://issues.apache.org/jira/browse/FLINK-31102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17699005#comment-17699005
]
Sergey Nuyanzin commented on FLINK-31102:
-----------------------------------------
Thanks, it already looks better
however there is still room for improvements
1. spark link still contains {{array_size}} in its name which is not related to
this issue
2. {quote}An ARRAY. If value is NULL, the result is NULL. {quote}
what is {{value}} here?
3. just a nit comment
{quote}postgresql
https://w3resource.com/PostgreSQL/postgresql_array_remove-function.php {quote}
it's better to refer to official documentation like
https://www.postgresql.org/docs/12/functions-array.html#ARRAY-FUNCTIONS-TABLE
rather than 3-rd party
> Add ARRAY_REMOVE supported in SQL & Table API
> ---------------------------------------------
>
> Key: FLINK-31102
> URL: https://issues.apache.org/jira/browse/FLINK-31102
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
> Affects Versions: 1.18.0
> Reporter: jackylau
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.18.0
>
>
> Remove all elements that equal to element from array.
> Syntax:
> array_remove(array, needle)
> Arguments:
> array: An ARRAY to be handled.
> Returns:
> An ARRAY. If value is NULL, the result is NULL.
> Examples:
> {code:sql}
> SELECT array_remove(array[1, 2, 3, null, 3], 3);
> -- [1,2,null]
> {code}
> See also
> spark
> [[https://spark.apache.org/docs/latest/api/sql/index.html#array_size]|https://spark.apache.org/docs/latest/api/sql/index.html#array_remove]
> presto [https://prestodb.io/docs/current/functions/array.html]
> postgresql
> [https://w3resource.com/PostgreSQL/postgresql_array_remove-function.php]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
