[GitHub] [flink] luoyuxia commented on a diff in pull request #22106: [FLINK-30659][hive] Drop flink-sql-parser-hive module

[via GitHub]

luoyuxia commented on code in PR #22106:
URL: https://github.com/apache/flink/pull/22106#discussion_r1133025171


##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/validate/FlinkSqlConformance.java:
##########
@@ -60,24 +54,12 @@ public boolean isHavingAlias() {
 
     @Override
     public boolean isSortByOrdinal() {
-        switch (this) {
-            case DEFAULT:
-            case HIVE:
-                return true;
-            default:
-                return false;
-        }
+        return false;
     }
 
     @Override
     public boolean isSortByAlias() {
-        switch (this) {
-            case DEFAULT:
-            case HIVE:
-                return true;
-            default:
-                return false;
-        }
+        return false;

Review Comment:
   Good catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org