Myasuka commented on code in PR #21835:
URL: https://github.com/apache/flink/pull/21835#discussion_r1133051134


##########
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java:
##########
@@ -437,18 +465,43 @@ public boolean runCleanupForEveryRecord() {
                 DEFAULT_ROCKSDB_COMPACT_FILTER_CLEANUP_STRATEGY =
                         new RocksdbCompactFilterCleanupStrategy(1000L);
 
+        /**
+         * Default value lets RocksDB control this feature as needed. For now, 
RocksDB will change
+         * this value to 30 days (i.e 30 * 24 * 60 * 60) so that every file 
goes through the
+         * compaction process at least once every 30 days if not compacted 
sooner.
+         */
+        static final long DEFAULT_PERIODIC_COMPACTION_SECONDS = 
0xfffffffffffffffeL;

Review Comment:
   I tried to run application without setting this config, and it shows that 
`Options.periodic_compaction_seconds: 0`, this is different from the docs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to