Aitozi commented on code in PR #21522:
URL: https://github.com/apache/flink/pull/21522#discussion_r1130546283


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/Schema.java:
##########
@@ -611,7 +611,9 @@ private void addResolvedColumns(List<Column> columns) {
                         } else if (c instanceof ComputedColumn) {
                             final ComputedColumn computedColumn = 
(ComputedColumn) c;
                             columnByExpression(
-                                    computedColumn.getName(), 
computedColumn.getExpression());
+                                    computedColumn.getName(),
+                                    new SqlCallExpression(
+                                            
computedColumn.getExpression().asSerializableString()));

Review Comment:
   Here, I modify the behavior by converting the resolvedExpression to an 
unresolvedExpression when using 
`Schema.newBuilder().fromResolvedSchema().build()`. This modification 
simplifies schema comparison during diff.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to