[ 
https://issues.apache.org/jira/browse/FLINK-4753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15580926#comment-15580926
 ] 

ASF GitHub Bot commented on FLINK-4753:
---------------------------------------

Github user tzulitai closed the pull request at:

    https://github.com/apache/flink/pull/2604


> Kafka 0.8 connector's Periodic Offset Committer should synchronize on 
> checkpoint lock
> -------------------------------------------------------------------------------------
>
>                 Key: FLINK-4753
>                 URL: https://issues.apache.org/jira/browse/FLINK-4753
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>             Fix For: 1.2.0
>
>
> The {{PeriodicOffsetCommitter}} doesn't synchronize on the checkpoint lock 
> when creating a copy of the partition offsets in the current state.
> I propose to pass the checkpoint lock into{{PeriodicOffsetCommitter}}, and  
> let {{PeriodicOffsetCommitter}} use {{Kafka08Fetcher#snapshotCurrentState()}} 
> to make the current state copy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to