yuzelin commented on code in PR #590:
URL: https://github.com/apache/flink-table-store/pull/590#discussion_r1135495972
##########
flink-table-store-common/src/test/java/org/apache/flink/table/store/lookup/hash/HashLookupStoreFactoryTest.java:
##########
@@ -157,52 +158,55 @@ public void testKeyLengthStartTwo() throws IOException {
assertThat(reader.lookup(toBytes(2454441))).isNull();
}
- @Test
- public void testDataOnTwoBuffers() throws IOException {
- Object[] keys = new Object[] {1, 2, 3};
- Object[] values =
- new Object[] {
- generateStringData(100), generateStringData(10000),
generateStringData(100)
- };
-
- int byteSize = toBytes(values[0]).length + toBytes(values[1]).length;
-
- // Write
- writeStore(file, keys, values);
-
- // Read
- factory = new HashLookupStoreFactory(0.75d, true, new
MemorySize(byteSize - 100));
- HashLookupStoreReader reader = factory.createReader(file);
- for (int i = 0; i < keys.length; i++) {
-
assertThat(reader.lookup(toBytes(keys[i]))).isEqualTo(toBytes(values[i]));
- }
- }
-
- @Test
- public void testDataSizeOnTwoBuffers() throws IOException {
- Object[] keys = new Object[] {1, 2, 3};
- Object[] values =
- new Object[] {
- generateStringData(100), generateStringData(10000),
generateStringData(100)
- };
-
- byte[] b1 = toBytes(values[0]);
- byte[] b2 = toBytes(values[1]);
- int byteSize = b1.length + b2.length;
- int sizeSize =
- VarLengthIntUtils.encodeInt(new DataOutputSerializer(4),
b1.length)
- + VarLengthIntUtils.encodeInt(new
DataOutputSerializer(4), b2.length);
-
- // Write
- writeStore(file, keys, values);
-
- // Read
- factory = new HashLookupStoreFactory(0.75d, true, new
MemorySize(byteSize + sizeSize + 3));
- HashLookupStoreReader reader = factory.createReader(file);
- for (int i = 0; i < keys.length; i++) {
-
assertThat(reader.lookup(toBytes(keys[i]))).isEqualTo(toBytes(values[i]));
- }
- }
+ // @Test
+ // public void testDataOnTwoBuffers() throws IOException {
+ // Object[] keys = new Object[] {1, 2, 3};
+ // Object[] values =
+ // new Object[] {
+ // generateStringData(100), generateStringData(10000),
+ // generateStringData(100)
+ // };
+ //
+ // int byteSize = toBytes(values[0]).length +
toBytes(values[1]).length;
+ //
+ // // Write
+ // writeStore(file, keys, values);
+ //
+ // // Read
+ // factory = new HashLookupStoreFactory(0.75d, true, new
MemorySize(byteSize - 100));
+ // HashLookupStoreReader reader = factory.createReader(file);
+ // for (int i = 0; i < keys.length; i++) {
+ //
assertThat(reader.lookup(toBytes(keys[i]))).isEqualTo(toBytes(values[i]));
+ // }
+ // }
+
+ // @Test
+ // public void testDataSizeOnTwoBuffers() throws IOException {
+ // Object[] keys = new Object[] {1, 2, 3};
+ // Object[] values =
+ // new Object[] {
+ // generateStringData(100), generateStringData(10000),
+ // generateStringData(100)
+ // };
+ //
+ // byte[] b1 = toBytes(values[0]);
+ // byte[] b2 = toBytes(values[1]);
+ // int byteSize = b1.length + b2.length;
+ // int sizeSize =
+ // VarLengthIntUtils.encodeInt(new DataOutputSerializer(4),
b1.length)
+ // + VarLengthIntUtils.encodeInt(new
DataOutputSerializer(4), b2.length);
+ //
+ // // Write
+ // writeStore(file, keys, values);
+ //
+ // // Read
+ // factory = new HashLookupStoreFactory(0.75d, true, new
MemorySize(byteSize + sizeSize +
+ // 3));
+ // HashLookupStoreReader reader = factory.createReader(file);
+ // for (int i = 0; i < keys.length; i++) {
+ //
assertThat(reader.lookup(toBytes(keys[i]))).isEqualTo(toBytes(values[i]));
+ // }
+ // }
Review Comment:
Should be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
