RamanVerma commented on code in PR #22150:
URL: https://github.com/apache/flink/pull/22150#discussion_r1136426195
##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java:
##########
@@ -241,6 +246,8 @@ public void close() throws Exception {
checkState(currentProducer.isClosed());
currentProducer = null;
});
+
+ checkAsyncException();
Review Comment:
Could you please explain the use case that we will catch by throwing
exception at this point. I assume this call will be useful under following
scenario
`write() -> close()` (so no `flush()` call made in between)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
