dmvk commented on code in PR #22153:
URL: https://github.com/apache/flink/pull/22153#discussion_r1136849988
##########
flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java:
##########
@@ -466,6 +468,7 @@ public static String checkForInstantiationError(Class<?>
clazz) {
}
}
+ @Nullable
Review Comment:
It's already in the separate hotfix commit, and the annotation is a no-op at
the runtime. It's only used for marking the method output as nullable for
static code analysis (findbugs, checker, whatever IDEA uses internally).
We don't even enforce anything during the Flink build, so it's just a hint
for the IDE writer telling you there's something you need to handle.
Creating a new ticket for change like this would add too much overhead with
no actual value (it doesn't need to be triaged, and the reader won't get any
more context on the change than from the commit message).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
