Aitozi commented on PR #21522: URL: https://github.com/apache/flink/pull/21522#issuecomment-1470090043
@luoyuxia Thanks for your detailed review. I have addressed your comments. > Do you mean for method CatalogTestUtil#checkEquals(CatalogTable t1, CatalogTable t2), t1/t2 may be ResolvedCatalogTable or DefaultCatalogTable. If it only happans in Hive, can we use method CatalogManagerMocks.createEmptyCatalogManager() .resolveCatalogTable()? So that, we won't need to add a new class TestSchemaResolver for this question: Yes, It's currently only need to resolve the schema for hive catalog. But in the `CatalogTest` it can not access to the `CatalogManagerMocks`. And hive catalog test should also run the `CatalogTest`'s test, So in the `CatalogTest` module, we'd better have a test tool which can resolve the Schema to ResolvedSchema for compare. Besides, `CatalogManagerMocks` can not resolve the expression actually, so the computed column and watermark spec can not be covered. The `TestSchemaResolver` will solve this and can served as a test harness when need `resolve`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
