zhangjun0x01 commented on code in PR #584:
URL: https://github.com/apache/flink-table-store/pull/584#discussion_r1138183538
##########
flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java:
##########
@@ -82,6 +82,20 @@ public class FlinkConnectorOptions {
+ "By default, if this option is not
defined, the planner will derive the parallelism "
+ "for each statement individually by also
considering the global configuration.");
+ public static final ConfigOption<Boolean> INFER_SCAN_PARALLELISM =
+ ConfigOptions.key("scan.infer-parallelism")
Review Comment:
Yes, your suggestion is also a reasonable idea. I guess that add the
`scan.parallelism` option is a simple way to let users set the scan
parallelism , but it is not intelligent enough, so we added the parallelism
inference.
So another solution is that we can also use infer-parallelism instead of
`scan.parallelism`. If we enable parallelism inference, we use split or bucket
number to as job parallelism. If not, we use the default parallelism of the
flink job.
But now that the system has added the `scan parallelism` option, I am
worried that some users who are using this option will be affected, so I do not
delete this option and add the switch for inferring parallelism . and make
its priority higher than `scan.parallelism`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
