dianfu commented on code in PR #22190:
URL: https://github.com/apache/flink/pull/22190#discussion_r1138237296
##########
flink-python/pyflink/datastream/tests/test_data_stream.py:
##########
@@ -1545,20 +1545,26 @@ def test_execute_and_collect(self):
test_data = ['pyflink', 'datastream', 'execute', 'collect']
ds = self.env.from_collection(test_data)
+ # test collect with limit
expected = test_data[:3]
actual = []
- for result in ds.execute_and_collect(limit=3):
- actual.append(result)
- self.assertEqual(expected, actual)
-
- expected = test_data
- ds = self.env.from_collection(collection=test_data,
type_info=Types.STRING())
- with ds.execute_and_collect() as results:
+ # for result in ds.execute_and_collect(limit=3):
Review Comment:
This is by mistake. Reverted~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
