[
https://issues.apache.org/jira/browse/FLINK-31208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701031#comment-17701031
]
Martijn Visser commented on FLINK-31208:
----------------------------------------
We should move this commit to the flink-connector-kafka repo, since we'll
remove the Kafka connector and won't be released with 1.18 anymore.
> KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits)
> -----------------------------------------------------------------------
>
> Key: FLINK-31208
> URL: https://issues.apache.org/jira/browse/FLINK-31208
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Kafka
> Affects Versions: 1.18.0
> Reporter: Hongshun Wang
> Assignee: Hongshun Wang
> Priority: Not a Priority
> Labels: pull-request-available, starter
> Fix For: 1.18.0
>
>
> KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits)
> ，which is no difference with its Parent class (SourceReaderBase). why not
> remove this override method?
>
> Relative code is here, which we can see is no difference?
> {code:java}
> //org.apache.flink.connector.kafka.source.reader.KafkaSourceReader#pauseOrResumeSplits
> @Override
> public void pauseOrResumeSplits(
> Collection<String> splitsToPause, Collection<String> splitsToResume) {
> splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
> }
> //org.apache.flink.connector.base.source.reader.SourceReaderBase#pauseOrResumeSplits
> @Override
> public void pauseOrResumeSplits(
> Collection<String> splitsToPause, Collection<String> splitsToResume) {
> splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
> }{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
