Aitozi commented on code in PR #21522:
URL: https://github.com/apache/flink/pull/21522#discussion_r1138416501
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java:
##########
@@ -111,25 +192,20 @@ public static TableSchema createTableSchema(
HiveTableUtil.relyConstraint((byte) 0));
// PK columns cannot be null
primaryKey.ifPresent(pk -> notNullColumns.addAll(pk.getColumns()));
- return createTableSchema(
- fields, hiveTable.getPartitionKeys(), notNullColumns,
primaryKey.orElse(null));
- }
- /** Create a Flink's TableSchema from Hive table's columns and partition
keys. */
- public static TableSchema createTableSchema(
- List<FieldSchema> cols,
- List<FieldSchema> partitionKeys,
- Set<String> notNullColumns,
- UniqueConstraint primaryKey) {
- List<FieldSchema> allCols = new ArrayList<>(cols);
- allCols.addAll(partitionKeys);
+ List<FieldSchema> allCols = new ArrayList<>(fields);
Review Comment:
Good catch, Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
