Aitozi commented on code in PR #21522:
URL: https://github.com/apache/flink/pull/21522#discussion_r1139726153
##########
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogITCase.java:
##########
@@ -503,16 +522,16 @@ public void testViewSchema() throws Exception {
CatalogView catalogView =
(CatalogView) hiveCatalog.getTable(new ObjectPath("db1",
"v1"));
- Schema viewSchema = catalogView.getUnresolvedSchema();
+ ResolvedSchema viewSchema =
Review Comment:
The main problem is the `UnresolvedDataType`
The `UnresolvedDataType` do not provide the `equals` to compare. It's
reasonable, because it's hard to say whether two `UnresolvedDataType` is equal.
IMO, the resolved version can be comparable 🤔.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
