luoyuxia commented on code in PR #22202:
URL: https://github.com/apache/flink/pull/22202#discussion_r1140150472
##########
flink-connectors/flink-sql-connector-hive-2.3.9/pom.xml:
##########
@@ -115,6 +115,10 @@ under the License.
<pattern>com.google</pattern>
<shadedPattern>org.apache.flink.hive.shaded.com.google</shadedPattern>
</relocation>
+ <relocation>
+
<pattern>org.apache.commons.lang3</pattern>
+
<shadedPattern>org.apache.flink.hive.shaded.org.apache.commons.lang3</shadedPattern>
Review Comment:
I'm not intended to do so. For the case that the hive depends some class
like `org.apache.common.xxx` but it hasn't shiped the class
`org.apache.common.xxx`. It's provided by hadoop-lib.
Without shadding, when we put hadoop-lib, hive-connector together, it works.
But after shade, it won't works as the class `org.apache.common.xxx` has
been shaded to `org.flink.shade.xxxx`, and hadoop-lib can't provide it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
