fredia commented on code in PR #21822:
URL: https://github.com/apache/flink/pull/21822#discussion_r1140928595
##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/DuplicatingStateChangeFsUploader.java:
##########
@@ -51,12 +52,12 @@
* <li>Store the meta of files into {@link ChangelogTaskLocalStateStore}
by
* AsyncCheckpointRunnable#reportCompletedSnapshotStates().
* <li>Pass control of the file to {@link
LocalChangelogRegistry#register} when
- * ChangelogKeyedStateBackend#notifyCheckpointComplete() , files of
the previous
- * checkpoint will be deleted by {@link
LocalChangelogRegistry#discardUpToCheckpoint} at
- * the same time.
+ * ChangelogKeyedStateBackend#buildSnapshotResult , files of the
previous checkpoint will
Review Comment:
Fixed.
##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java:
##########
@@ -369,7 +390,6 @@ public void confirm(SequenceNumber from, SequenceNumber to,
long checkpointId) {
changelogRegistry.stopTracking(localHandle);
localChangelogRegistry.register(localHandle,
checkpointId);
});
- localChangelogRegistry.discardUpToCheckpoint(checkpointId);
Review Comment:
Fixed, retain the call of `discardUpToCheckpoint` here and delete the call
in `subsume()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
