chucheng92 commented on code in PR #22215:
URL: https://github.com/apache/flink/pull/22215#discussion_r1141572379
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowTablesOperation.java:
##########
@@ -104,4 +112,33 @@ public String asSummaryString() {
}
return builder.toString();
}
+
+ @Override
+ public TableResultInternal execute(Context ctx) {
+ final Set<String> tables;
+ if (preposition == null) {
+ tables = ctx.getCatalogManager().listTables();
Review Comment:
hi. there is a different point from previous behavior. the previous way
return sorted result.
```java
return
catalogManager.listTables().stream().sorted().toArray(String[]::new);
```
Not just show tables, other operations may also occur. it may pass the
current test, but true behavior is changed. So we should be careful to check
the result by `getCatalogManager`.
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ExecutableOperation.java:
##########
@@ -57,5 +59,9 @@ interface Context {
FunctionCatalog getFunctionCatalog();
ModuleManager getModuleManager();
+
+ ResourceManager getResourceManager();
Review Comment:
thanks. got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
