mbalassi commented on code in PR #548:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/548#discussion_r1142261062
##########
flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/Fabric8FlinkStandaloneKubeClient.java:
##########
@@ -57,14 +58,14 @@ public void stopAndCleanupCluster(String clusterId) {
.apps()
.deployments()
.withName(StandaloneKubernetesUtils.getJobManagerDeploymentName(clusterId))
- .cascading(true)
+ .withPropagationPolicy(DeletionPropagation.ORPHAN)
Review Comment:
That makes more sense, to me - the javadoc was ambiguous tbh. I prefer
foreground unless @usamj or @dannycranmer disagrees.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
