snuyanzin commented on code in PR #22144:
URL: https://github.com/apache/flink/pull/22144#discussion_r1142753109
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java:
##########
@@ -178,6 +181,125 @@ Stream<TestSetSpec> getTestSetSpecs() {
null
},
DataTypes.ARRAY(
- DataTypes.ROW(DataTypes.BOOLEAN(),
DataTypes.DATE()))));
+ DataTypes.ROW(DataTypes.BOOLEAN(),
DataTypes.DATE()))),
+
TestSetSpec.forFunction(BuiltInFunctionDefinitions.ARRAY_REMOVE)
+ .onFieldsWithData(
+ new Integer[] {1, 2, 2},
+ null,
+ new String[] {"Hello", "World"},
+ new Row[] {
+ Row.of(true, LocalDate.of(2022, 4, 20)),
+ Row.of(true, LocalDate.of(1990, 10, 14)),
+ null
+ },
+ new Integer[] {null, null, 1},
+ new Integer[][] {
+ new Integer[] {1, null, 3}, new Integer[]
{0}, new Integer[] {1}
+ },
+ new Map[] {
+ CollectionUtil.map(entry(1, "a"), entry(2,
"b")),
+ CollectionUtil.map(entry(3, "c"), entry(4,
"d")),
+ null
+ })
+ .andDataTypes(
+ DataTypes.ARRAY(DataTypes.INT()),
+ DataTypes.ARRAY(DataTypes.INT()),
+ DataTypes.ARRAY(DataTypes.STRING()).notNull(),
+ DataTypes.ARRAY(
+ DataTypes.ROW(DataTypes.BOOLEAN(),
DataTypes.DATE())),
+ DataTypes.ARRAY(DataTypes.INT()),
+
DataTypes.ARRAY(DataTypes.ARRAY(DataTypes.INT())),
+ DataTypes.ARRAY(DataTypes.MAP(DataTypes.INT(),
DataTypes.STRING())))
+ // ARRAY<INT>
+ .testResult(
+ $("f0").arrayRemove(2),
+ "ARRAY_REMOVE(f0, 2)",
+ new Integer[] {1},
+ DataTypes.ARRAY(DataTypes.INT()).nullable())
+ .testResult(
+ $("f0").arrayRemove(42),
+ "ARRAY_REMOVE(f0, 42)",
+ new Integer[] {1, 2, 2},
+ DataTypes.ARRAY(DataTypes.INT()).nullable())
+ .testResult(
+ $("f0").arrayRemove(
+ lit(null, DataTypes.SMALLINT())
+
.cast(DataTypes.INT())),
+ "ARRAY_REMOVE(f0, cast(NULL AS INT))",
+ new Integer[] {1, 2, 2},
+ DataTypes.ARRAY(DataTypes.INT()).nullable())
+ // ARRAY<INT> of null value
+ .testResult(
+ $("f1").arrayRemove(12),
+ "ARRAY_REMOVE(f1, 12)",
+ null,
+ DataTypes.ARRAY(DataTypes.INT()).nullable())
+ .testResult(
+ $("f1").arrayRemove(null),
+ "ARRAY_REMOVE(f1, NULL)",
+ null,
+ DataTypes.ARRAY(DataTypes.INT()).nullable())
+ // ARRAY<STRING> NOT NULL
+ .testResult(
+ $("f2").arrayRemove("Hello"),
+ "ARRAY_REMOVE(f2, 'Hello')",
+ new String[] {"World"},
+ DataTypes.ARRAY(DataTypes.STRING()).notNull())
+ .testResult(
+ $("f2").arrayRemove(
+ lit(null, DataTypes.STRING())
+
.cast(DataTypes.STRING())),
+ "ARRAY_REMOVE(f2, cast(NULL AS VARCHAR))",
Review Comment:
i do not see a big difference between these tests and tests for int types...
`ARRAY_REMOVE` invokes same code for both.... Probably just one (int or varchar
is enough)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
