lincoln-lil commented on code in PR #22222:
URL: https://github.com/apache/flink/pull/22222#discussion_r1142957354
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdWindowProperties.scala:
##########
@@ -252,13 +254,40 @@ class FlinkRelMdWindowProperties private extends
MetadataHandler[FlinkMetadata.W
}
def getWindowProperties(
- rel: StreamPhysicalWindowAggregate,
+ rel: StreamPhysicalWindowAggregateBase,
mq: RelMetadataQuery): RelWindowProperties = {
+ rel match {
Review Comment:
How about just overriding three methods of the concrete subclasses here? so
that we can avoid forced type conversions here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
