huwh commented on code in PR #22196:
URL: https://github.com/apache/flink/pull/22196#discussion_r1143240702
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceDeclaration.java:
##########
@@ -51,7 +51,7 @@ public int getNumNeeded() {
return numNeeded;
}
- public Collection<InstanceID> getUnwantedWorkers() {
+ public Set<InstanceID> getUnwantedWorkers() {
Review Comment:
unmodifiableCollection does not implement equals method. This make unit test
hard to compare whether ResourceDeclaration is the same value.
also updated in commit message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
