wuchong commented on PR #22220: URL: https://github.com/apache/flink/pull/22220#issuecomment-1477976541
Hi @chucheng92 , I think it's a good idea to reuse `AlterSchemaConverter`. But the current `AlterSchemaConverter` is a little confusing because we have so many converters. Actually, `AlterSchemaConverter` is also bloated because it stuffs many SqlNodes conversions for ALTER statements. Maybe we should split the methods of `AlterSchemaConverter` into each SqlNodeConverters. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
