Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2648#discussion_r83662569
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
 ---
    @@ -80,38 +81,38 @@
        // 
------------------------------------------------------------------------
     
        private final List<String> topics;
    -   
    +
        /** The schema to convert between Kafka's byte messages, and Flink's 
objects */
        protected final KeyedDeserializationSchema<T> deserializer;
     
        /** The set of topic partitions that the source will read */
        protected List<KafkaTopicPartition> subscribedPartitions;
    -   
    +
        /** Optional timestamp extractor / watermark generator that will be run 
per Kafka partition,
         * to exploit per-partition timestamp characteristics.
         * The assigner is kept in serialized form, to deserialize it into 
multiple copies */
        private SerializedValue<AssignerWithPeriodicWatermarks<T>> 
periodicWatermarkAssigner;
    -   
    +
        /** Optional timestamp extractor / watermark generator that will be run 
per Kafka partition,
    -    * to exploit per-partition timestamp characteristics. 
    +    * to exploit per-partition timestamp characteristics.
         * The assigner is kept in serialized form, to deserialize it into 
multiple copies */
        private SerializedValue<AssignerWithPunctuatedWatermarks<T>> 
punctuatedWatermarkAssigner;
     
    -   private transient OperatorStateStore stateStore;
    +   private transient ListState<Serializable> offsetsStateForCheckpoint;
    --- End diff --
    
    This can can have a more concrete type. You changed 
`OperatorStateStore.getSerializableListState` to this:
    ```
    <T extends Serializable> ListState<T> getSerializableListState(String 
stateName) throws Exception;
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to