[ 
https://issues.apache.org/jira/browse/FLINK-31464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703555#comment-17703555
 ] 

Timo Walther commented on FLINK-31464:
--------------------------------------

bq. But this is a huge technical debt. I think it's better to refactor it after 
we finish this cleanup.

Absolutely, but maybe we can already write some JavaDoc about the interfaces so 
that the technical debt will not become larger. And methods in Context of 
SqlNodeConverter are deprecated or contain a warning that e.g. catalog manager 
should not be accessed.



> Move SqlNode conversion logic out from SqlToOperationConverter
> --------------------------------------------------------------
>
>                 Key: FLINK-31464
>                 URL: https://issues.apache.org/jira/browse/FLINK-31464
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Table SQL / Planner
>            Reporter: luoyuxia
>            Assignee: xuzhiwen
>            Priority: Major
>
> Similar to FLINK-31368, the  `SqlToOperationConverter` is a bit bloated. We 
> can refactor it to avoid the code length for this class grow quickly.
> We can follow the idea proposed in FLINK-31368.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to