[ 
https://issues.apache.org/jira/browse/FLINK-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated FLINK-4849:
--------------------------
    Description: 
{code}
      String trustStorePassword = sslConfig.getString(
        ConfigConstants.SECURITY_SSL_TRUSTSTORE_PASSWORD,
        null);
...
      try {
        trustStoreFile = new FileInputStream(new File(trustStoreFilePath));
        trustStore.load(trustStoreFile, trustStorePassword.toCharArray());
{code}
If trustStorePassword is null, the load() call would throw NPE.

  was:
{code}
      String keystoreFilePath = sslConfig.getString(
        ConfigConstants.SECURITY_SSL_KEYSTORE,
        null);
...
      try {
        keyStoreFile = new FileInputStream(new File(keystoreFilePath));
{code}
If keystoreFilePath is null, the File ctor would throw NPE.


> trustStorePassword should be checked against null in 
> SSLUtils#createSSLClientContext
> ------------------------------------------------------------------------------------
>
>                 Key: FLINK-4849
>                 URL: https://issues.apache.org/jira/browse/FLINK-4849
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>       String trustStorePassword = sslConfig.getString(
>         ConfigConstants.SECURITY_SSL_TRUSTSTORE_PASSWORD,
>         null);
> ...
>       try {
>         trustStoreFile = new FileInputStream(new File(trustStoreFilePath));
>         trustStore.load(trustStoreFile, trustStorePassword.toCharArray());
> {code}
> If trustStorePassword is null, the load() call would throw NPE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to