ASF GitHub Bot commented on FLINK-4715:

Github user StephanEwen commented on a diff in the pull request:

    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
    @@ -1183,47 +1220,48 @@ public String toString() {
        private static class TaskCanceler implements Runnable {
    -           private final Logger logger;
                private final AbstractInvokable invokable;
                private final Thread executer;
    -           private final String taskName;
                private final long taskCancellationIntervalMillis;
                private final ResultPartition[] producedPartitions;
                private final SingleInputGate[] inputGates;
    +           private final CountDownLatch watchDogLatch;
                public TaskCanceler(
    -                           Logger logger,
    --- End diff --
    I think the logger was added to prevent that the compiler needs to inject 
static bridge methods to access it. Why not keep it?

> TaskManager should commit suicide after cancellation failure
> ------------------------------------------------------------
>                 Key: FLINK-4715
>                 URL: https://issues.apache.org/jira/browse/FLINK-4715
>             Project: Flink
>          Issue Type: Improvement
>          Components: TaskManager
>    Affects Versions: 1.2.0
>            Reporter: Till Rohrmann
>            Assignee: Ufuk Celebi
>             Fix For: 1.2.0
> In case of a failed cancellation, e.g. the task cannot be cancelled after a 
> given time, the {{TaskManager}} should kill itself. That way we guarantee 
> that there is no resource leak. 
> This behaviour acts as a safety-net against faulty user code.

This message was sent by Atlassian JIRA

Reply via email to