[ 
https://issues.apache.org/jira/browse/FLINK-31405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704101#comment-17704101
 ] 

Chesnay Schepler commented on FLINK-31405:
------------------------------------------

[~Weijie Guo] Please remember to set the fix version when closing the ticket.

> Refactor tests to git rid of timeout of CompletableFuture assertions.
> ---------------------------------------------------------------------
>
>                 Key: FLINK-31405
>                 URL: https://issues.apache.org/jira/browse/FLINK-31405
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Tests
>    Affects Versions: 1.18.0
>            Reporter: Weijie Guo
>            Assignee: Weijie Guo
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.18.0
>
>
> In general, we want to avoid relying on local timeouts in the Flink test 
> suite to get additional context (thread dump) in case something gets 
> stuck(see [Code Style and Quality 
> Guide|https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#avoid-timeouts-in-junit-tests]).
> Some of timeout in tests are introduced by assertions for {{CompleteFuture}}. 
> After FLINK-31385, we can refactor these tests to git rid of timeout for 
> {{CompletableFuture}} assertions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to