PatrickRen commented on code in PR #153:
URL: https://github.com/apache/flink-docker/pull/153#discussion_r1146445138
##########
.github/workflows/snapshot.yml:
##########
@@ -38,12 +38,12 @@ jobs:
matrix:
java_version: [8, 11]
build:
- - flink_version: 1.17-SNAPSHOT
+ - flink_version: 1.18-SNAPSHOT
branch: dev-master
+ - flink_version: 1.17-SNAPSHOT
+ branch: dev-1.17
- flink_version: 1.16-SNAPSHOT
branch: dev-1.16
- - flink_version: 1.15-SNAPSHOT
Review Comment:
According to the discussion we still need to release 1.15.5 as the final
flushing version. Then I think 1.15 related contents should be kept until the
final 1.15.5 is released. Otherwise we will never be able to release the 1.15.5
to the docker-library/official-images repo, as a new release requires to point
to a commit on master.
IIUC the workflow handling an end-of-support version (let say 1.15 here)
would be:
- We keep 1.15 related contents on master
- Once the final version 1.15.5 is ready, release the Docker image following
the guide in README.md
- Remove 1.15 related contents from master after 1.15.5 is successfully
published to Docker official
- Remove 1.15 related contents from
[library/flink](https://github.com/docker-library/official-images/blob/master/library/flink)
in official-images repo
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
